search

bookwyrm-social / bookwyrm

Social reading and reviewing, decentralized with ActivityPub
http://joinbookwyrm.com/
Other
2.22k stars 259 forks source link

Special characters in passwords causing errors #2819

Open tofuwabohu opened 1 year ago

tofuwabohu commented 1 year ago

Describe the bug In some cases, character in passwords cause Bookwyrm to crash. We've had an issue with getting server error 500 due to redis not recognizing the password (contained {) after an instance update, the same password had been working for 2 years before that update. We've also had similar behaviour with a ) in the SMTP password - this was extra weird since while updating the instance, the password had to be in "" for the update not to crash, but after the update we had to remove the "" and run docker compose up again for it to work in runtime. Escaping " or ' works in some cases but not in all.

I believe this to be a thing in docker compose or any underlying libraries but I didn't pinpoint any further at some point and changed the passwords instead. Mostly posting this so someone with similar issues can find it.

Maybe this is a thing to mention in the set up documentation?

To Reproduce Steps to reproduce the behavior:

  1. Add some special characters in your passwords
  2. Update the instance

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Instance wyrms.de

mouse-reeve commented 1 year ago

I think this is related: https://github.com/bookwyrm-social/bookwyrm/pull/1805