search

boonebgorges / buddypress-docs

GNU General Public License v3.0
106 stars 44 forks source link

Theme Compat: Return buffer template part #740

Closed r-a-y closed 9 months ago

r-a-y commented 9 months ago

Came across an issue where on a group doc page, the doc navigation and tabs were displaying twice on the page.

The issue is during theme compat, bp_buffer_template_part() is being used without setting the $echo parameter to false.

This bug also affects BP Docs 2.1.x, so I'm not sure why I'm seeing this problem now :shrug: Anyway, commit 89747f4 fixes this and follows how BP does theme compat for their native components.

boonebgorges commented 9 months ago

Thanks for this, @r-a-y !

This bug also affects BP Docs 2.1.x, so I'm not sure why I'm seeing this problem now

Could be related to BP 12.0.

We are discussing this along with some other changes that affect block-related themes in #738. See also #728.

r-a-y commented 9 months ago

Could be related to BP 12.0.

On our install, this bug is showing up on BP 11.4.0 and BP Docs 2.1.8 so I don't think this is related to BP 12.

boonebgorges commented 9 months ago

Yeah. Docs 2.2.0 also required some changes in load order in order to accommodate BP 12.0, so it could be related to that. Anyway, thanks for the PR - we will push out a release soon.

r-a-y commented 9 months ago

Looks like @dcavins already fixed this in 2.2.x with this commit https://github.com/boonebgorges/buddypress-docs/commit/28d067e9d2a6b1802217929c9056c84f876ad76f .

I guess I was working off an older 2.2.x branch somehow.

dcavins commented 9 months ago

@r-a-y That change wasn't in 2.2.x, it was in a parallel branch where I was working on wider themes and block stuff. Thanks a lot for contributing, and I hope you are well!