search

boostorg / boost

Super-project for modularized Boost
https://github.com/boostorg/wiki/wiki/Getting-Started%3A-Overview
Boost Software License 1.0
7.23k stars 1.77k forks source link

MSVC 1941 is not supported when using boost from cmake #944

Closed imrichardcole closed 3 months ago

imrichardcole commented 3 months ago

The generated cmake file - BoostDetectToolset-1.85.0.cmake includes the following:

92 - if((MSVC_VERSION GREATER 1929) AND (MSVC_VERSION LESS 1940))

Which is used to detect the vc143 toolset. I'm using the latest compiler for v143 and this version comes back as 1941 so I get an unsupported toolset error when trying to use boost in my cmake project.

If I change the above to:

92 - if((MSVC_VERSION GREATER 1929) AND (MSVC_VERSION LESS 1941))

And it works. I'm happy to raise a PR for this if people agree it's a good step forward.

imrichardcole commented 3 months ago

Apologies - it seems this is already fixed in 1.86.0:

https://github.com/boostorg/boost_install/commit/3f67136ec1e7855f29c40db8949e763ff73c840f

imrichardcole commented 3 months ago

Not needed as fixed in latest version