search

boostorg / lockfree

Boost.Lockfree
125 stars 86 forks source link

Fix https://github.com/boostorg/lockfree/issues/35 #55

Closed austin-beer closed 4 years ago

austin-beer commented 4 years ago
timblechmann commented 4 years ago

it basically reverts 505c1c04c18939cfd8fbf58386230ee78f4549ad ... iirc this patch would prevent the classes from being externally instantiated.

afaict the proper way to go is to use enable_if

timblechmann commented 4 years ago

could you separate out the doc strings from the assertions? i'm happy to merge that part

austin-beer commented 4 years ago

Closing and re-opening PR to re-trigger CI builds

austin-beer commented 4 years ago

The build failures are only with clang, and appear to be unrelated to changes in this PR, so I think it can still be merged.

austin-beer commented 4 years ago

The previous commit fixed one of the two CI failures (it fixed clang on linux with libstdc++).

timblechmann commented 4 years ago

thanks a lot, also for the CI failure fix!