search

boostorg / ptr_container

Boost.org ptr_container module
http://boost.org/libs/ptr_container
Boost Software License 1.0
13 stars 41 forks source link

Inheriting std::iterator is deprecated in C++17 #15

Closed DanielaE closed 6 years ago

DanielaE commented 6 years ago

Therefore replace inheritance by lifting std::iterator's members into the derived class.

Signed-off-by: Daniela Engert dani@ngrt.de

mclow commented 6 years ago

I did some checks, and found no places where anyone is checking to see if these iterators are derived from std::iterator, so I think that this is a benign change.

I'm a bit disturbed that there are no tests for these iterators (only tests for functions that create them), but this patch doesn't make that worse.