search

boostorg / ptr_container

Boost.org ptr_container module
http://boost.org/libs/ptr_container
Boost Software License 1.0
13 stars 41 forks source link

Fix ptr_list compile break #5

Closed MarcelRaad closed 6 years ago

MarcelRaad commented 9 years ago

https://github.com/boostorg/utility/commit/651a869d4f9479dd3dfdd0293305a60b8c8d0e1c broke the ptr_list regression tests as boost::next now uses operator+= if available instead of std::advance, which doesn't work for list iterators.

mclow commented 9 years ago

My first response to this is to fix boost::next. Looking at that now.

MarcelRaad commented 9 years ago

Thanks! That would be even better of course.

pdimov commented 6 years ago

Looks like this is no longer an issue.

MarcelRaad commented 6 years ago

Yes, I can confirm this has been fixed by https://github.com/boostorg/iterator/commit/d251a6f5154cdda5bb1622923220e7b3428bebf5.

pdimov commented 6 years ago

Marcel, do you use ptr_container? There are many unmerged changes in develop and someone who cares about the library and is familiar with it needs to go through them, review them and determine what needs to be merged.

pdimov commented 6 years ago

Never mind, I decided to just go ahead and merge.

MarcelRaad commented 6 years ago

Yes, I've been using the develop branch integrated into official Boost releases for a long time on older compilers (MSVC 9 SP1, GCC 4.2.1, clang C++03) without any problems. Thanks!

pdimov commented 6 years ago

Thanks for the confirmation. :-)

pdimov commented 6 years ago

Are there other Boost libraries for which you use the develop branch and would like it merged?

MarcelRaad commented 6 years ago

@pdimov Yes, tuple, thanks for asking. The released version has an implicit one-element constructor, which regularly led to bugs in code I'm working with.