Undefined behavior - Githubissues

bootphon / ABXpy

ABX discrimination task in python

https://docs.cognitive-ml.fr/ABXpy

MIT License

43 stars 16 forks source link

Undefined behavior #14

Closed louisabraham closed 5 years ago

louisabraham commented 6 years ago

Some outputs are determined by an iteration order on sets / dicts. They are guaranteed to be consistent for multiple executions, but not across versions.

I think the csv test in test_frozen_analyze is the only one concerned.

Do you prefer:

to correct the undefined behavior (more complicated and since the tests will be changed there is a risk of breaking something but it is ultimately cleaner)?
to make separate tests for different Python versions (simplest to implement)?

mmmaat commented 6 years ago

The ideal fix is to replace the problematic dict by an OrderedDict and update the impacted tests, right? If so, you can do it of course!

mmmaat commented 6 years ago

Having several tests for several Python version is error prone and a bit dirty I guess, but let's go if the 1st solution is too complicated.

mmmaat commented 5 years ago

Fixed as of ABXpy-0.4.2.