boppreh / steamgrid

Downloads images to fill your Steam grid view
MIT License
675 stars 42 forks source link

Fix some non-steam shortcuts being skipped #114

Closed kmicki closed 2 years ago

kmicki commented 2 years ago

Regex expression parsing shortcuts.vfd file has been modified so it doesn't skip shortcuts where 4-byte appid is translated into less-than-4 character UTF-8 text. Before fix: appid had to be matched to exactly 4 characters. But regexp matches UTF-8 so sometimes it could be 1,2 or 3 characters. After fix: appid is matched to an UTF-8 text of 1 to 4 characters. Matched byte length of appid is always 4.

Fixes #110.

boppreh commented 2 years ago

Looks good, thanks for the contribution!

boppreh commented 2 years ago

(by the way, this was not automated, I just happened to catch your PR quickly and understand the regex expression well)