Round canvas dimensions in `resizeIfNeeded_`. Fixes #104

borismus / webvr-boilerplate

A starting point for web-based VR experiences that work on all VR headsets.

Apache License 2.0

1.8k stars 451 forks source link

Round canvas dimensions in `resizeIfNeeded_`. Fixes #104 #107

Closed brianchirls closed 8 years ago

brianchirls commented 8 years ago

It occurs to me that it might make more sense to fix this on the three.js side. I leave it up to you @borismus.

brianchirls commented 8 years ago

BTW, this is your friendly reminder to please bump the version if/when you decide to accept this PR.

borismus commented 8 years ago

For the record, would rather fix this in THREE.js.

brianchirls commented 8 years ago

Yeah, so would I. And it's been fixed! https://github.com/mrdoob/three.js/issues/7995

I'm gonna go ahead and close this PR and #104. But note that this patch also fixed a missing semi-colon and a couple of non-strict-equals. You may want to fix those elsewhere.