Closed nh2 closed 8 years ago
... since this can also happen when there is no "hard error" at all, e.g. when your device is not in the list DPDB list (e.g. when it's a desktop machine without any VR device attached).
This should be a warning, because
console.warn('No DPDB device match.'); return null;
is a warning too, but since null is returned, it becomes an error as console.error('Failed to recalculate device parameters.'); straight after.
null
console.error('Failed to recalculate device parameters.');
Real errors are already logged with console.error in calcDeviceParams_, e.g. console.error('DPDB has unexpected format version.');.
console.error
calcDeviceParams_
console.error('DPDB has unexpected format version.');
... since this can also happen when there is no "hard error" at all, e.g. when your device is not in the list DPDB list (e.g. when it's a desktop machine without any VR device attached).
This should be a warning, because
is a warning too, but since
nullis returned, it becomes an error asconsole.error('Failed to recalculate device parameters.');straight after.Real errors are already logged with
console.errorincalcDeviceParams_, e.g.console.error('DPDB has unexpected format version.');.