[create modules] Exclude react from the bundle by default

botpress / v12

Botpress OSS – v12

https://v12.botpress.com

GNU Affero General Public License v3.0

83 stars 91 forks source link

[create modules] Exclude react from the bundle by default #41

Closed slvnperron closed 7 years ago

slvnperron commented 7 years ago

In the default webpack.js file, exclude React (and ReactDOM) from the bundle. The reason is because if we don't there's two different versions of React running concurrently, causing issues with ReactDOM

Joepena commented 7 years ago

botpress/botpress#78 I have made a pull request for my commit to this issue. I have added the 'externals' configuration option to exclude react and reactDOM.

slvnperron commented 7 years ago

Fixed in botpress/botpress#78 . thanks again Joe :1st_place_medal: :)