bottlerocket-os / bottlerocket

An operating system designed for hosting containers
https://bottlerocket.dev
Other
8.64k stars 508 forks source link

settings-committer fails if there are no pending changes #4021

Closed bcressey closed 3 months ago

bcressey commented 3 months ago

Image I'm using: aws-k8s-1.28-nvidia

What I expected to happen: settings-committer is run before sundog, pluto, and thar-be-settings to commit any new settings in the launch transaction. It should tolerate an empty transaction since there won't always be new settings to generate, especially on a reboot.

What actually happened: System failed to reboot with this error:

[    9.329884] Starting User-specified setting generators...
[    9.441691] settings-committer[1141]: Error sending POST to /tx/commit?tx=bottlerocket-launch: Tried to commit with no pending changes
[FAILED] Failed to start User-specified setting generators.

How to reproduce the problem: Launch an aws-k8s-* node and reboot.

bcressey commented 3 months ago

@sumukhballal can you take a look? Might be related to your recent changes in apiserver.