search

bottlerocket-os / bottlerocket

An operating system designed for hosting containers
https://bottlerocket.dev
Other
8.64k stars 508 forks source link

Mount static kmod as /usr/local/sbin/modprobe #4037

Closed vigh-m closed 3 months ago

vigh-m commented 3 months ago

Issue number:

Updates #3968

Description of changes: This change mounts the static kmod built in https://github.com/bottlerocket-os/bottlerocket/pull/3981 into a customer container.

This time, the mount target is /usr/local/sbin/modprobe

Testing done:

I ran the script here to generate the kubernetes podspec to validate modprobe on 23 containers including:

No errors on any of them.

No errors running internal testing for ECS either

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

vigh-m commented 3 months ago

Added Signed-off and exec option based on comments

vigh-m commented 3 months ago 
 NAME                                TYPE          STATE             PASSED      FAILED      SKIPPED   BUILD ID      LAST UPDATE
 x86-64-aws-ecs-2-conformance        Test          passed                 1           0            0   ec021fde      2024-06-06T20:52:09Z
 x86-64-aws-ecs-2-quick              Test          passed                 1           0            0   ec021fde      2024-06-06T20:50:01Z
 x86-64-aws-k8s-128-conformance      Test          passed               384           0     7009   ec021fde      2024-06-06T22:07:43Z
 x86-64-aws-k8s-128-quick            Test          passed                 5           0     7388   ec021fde      2024-06-06T17:59:54Z
 x86-64-aws-k8s-128                  Resource      completed                                           ec021fde      2024-06-06T17:57:42Z