bottlerocket-os / bottlerocket

An operating system designed for hosting containers
https://bottlerocket.dev
Other
8.4k stars 498 forks source link

Allow parallel image pulls #4058

Open ozahavi opened 3 weeks ago

ozahavi commented 3 weeks ago

What I'd like: To set the following via user data -

serialzeImagePulls:false
maxParallelImagePulls: 10
larvacea commented 2 weeks ago

Are you referring to the kubelet options with these names? If so, are you using EKS and one of the bottlerocket aws-eks variants? If so, the eksctl tool does have a mechanism for adding custom configuration to the nodes it provisions. See https://eksctl.io/usage/customizing-the-kubelet/ for details. If that doesn't meet your requirements, please do let us know which Bottlerocket variant you are running and (if these are the kubernetes options) how you configure and control your cluster, so we can better understand how we can help.

bcressey commented 2 weeks ago

@larvacea that option doesn't work for Bottlerocket - changes to files in /etc, like kubelet's config, need to come through as settings so they can survive a node restart or settings change.

bcressey commented 2 weeks ago

@ozahavi FWIW all aws-k8s-* AMIs default to serializeImagePulls: false, and maxParallelImagePulls is not set. Is your goal to limit the number of parallel image pulls?

ozahavi commented 1 week ago

@ozahavi FWIW all aws-k8s-* AMIs default to serializeImagePulls: false, and maxParallelImagePulls is not set. Is your goal to limit the number of parallel image pulls?

My goal is to pull in parallel. I am using bottlerocket-aws-k8s-1.27-x86_64-v1.19.5-64049ba8 and images are not pulled in parallel.

Pulling image "REDACTED.dkr.ecr.us-east-1.amazonaws.com/h2oai-dai-init-container:0.0.7"
2024-06-27T16:14:58+03:00

Pulling image "REDACTED.dkr.ecr.us-east-1.amazonaws.com/thirdparty-linkerd-proxyinit:v2.2.1"
2024-06-27T16:15:11+03:00

Pulling image "REDACTED.dkr.ecr.us-east-1.amazonaws.com/thirdparty-linkerd-proxy:v2.14.0"
2024-06-27T16:15:12+03:00

Pulling image "REDACTED.dkr.ecr.us-east-1.amazonaws.com/manager:0.7.0"
2024-06-27T16:15:13+03:00