bounswe / bounswe2017group5

Interestr - Build your own interest-based community
MIT License
6 stars 3 forks source link

Fix tests and fix posts and comments bug #183

Closed karacasoft closed 6 years ago

karacasoft commented 6 years ago

About

To fix #171, I thought we should fix the tests first. There were a lot of weak assertions and simply wrong test cases. There are also missing cases, but I'll go through them on the next iteration of fixing #171. I've fixed the Post and Comments not being created issue.

On the way, I fixed some logic on Comments which was taking 'owner' as an argument from outside. I have changed it to use the currently logged in user. I want the frontend team to check if their comment system is working.

I've changed the way both Comments and Posts work now. I want frontend to be checked if API is being used for Posts and Comments. To fix any issues, you have to send authorization information to API. Either session or Token authorization is accepted. API will request authorization at some point so getting this set up will actually buy you time from future.

Changes

karacasoft commented 6 years ago

I actually want someone to test the frontend. So will let this stay for a while.

karacasoft commented 6 years ago

I did the changes @Morgazipa requested. Waiting for the next review...