bounswe / bounswe2017group5

Interestr - Build your own interest-based community
MIT License
6 stars 3 forks source link

[WIP] Frontend for annotations with a Firefox add-on #205

Closed ThoAppelsin closed 6 years ago

ThoAppelsin commented 6 years ago

About

This pull request aims to bring annotations to our application with a plugin for Firefox 57.

It is almost complete. Demonstrably complete, in fact. I hope to add a couple of more before we merge it with the master. If you wish, however, you can just do it after adding the address of our website to allowedHosts array within sidebar/panel.js.

Also, please make sure that everything will also work on the server on remote. Check the addresses, etc. Check them on the back-end, too, please.

Features to come (may not be there before the demo):

Changes

Visuals

screen shot 2017-12-28 at 14 28 49

Usage

smddzcy commented 6 years ago

It looks cool, can we merge?

smddzcy commented 6 years ago

Tests are failing though, please run python manage.py makemigrations --merge and commit the new merge migration.

ThoAppelsin commented 6 years ago

I pulled the master, should be OK now. I was working on the disabling features, however. Will you merge without them?

It is actually fine to do so. It would be great if we had some annotations on our website instead of the lousy disabling. We can hotfix disabling into the system anyway. Disabling of the add-on, does not even require an update on the server, anyway.

ThoAppelsin commented 6 years ago

But please do check the back-end to see if there is anything specific about 127.0.0.1 or interestr.com, that may cause problems when pushed onto the server where the ip address is 35, something.