/api/v1/profiles Endpoint

bounswe / bounswe2018group7

hiStory | A Living History Project

7 stars 1 forks source link

/api/v1/profiles Endpoint #137

Closed cburakaygun closed 5 years ago

cburakaygun commented 5 years ago

Hello,

This PR contains the implementation of Profile . Related documentation can be found here.

Fixes #130

eneskosr commented 5 years ago

Hi Cemal, there is a problem with the ban mechanism. I am trying to ban an admin user, from an admin user, sending a request PATCH api/v1/profiles/<username> with a request body { "ban" : true }, however it gives a type error saying that it doesnt accept bool and waiting for str, bytes or bytearray. Can you check it out?

cburakaygun commented 5 years ago

Hello @eneskosr

Thanks for the feedback. I pushed a commit to fix the problem. Can you check again?

eneskosr commented 5 years ago

Hi @cburakaygun

Thanks for the quick fix. It looks fine, now. I have tested all functionalities and they are working as expected.

cburakaygun commented 5 years ago

You can approve the changes by clicking "Review changes" button under Files changed section.

eneskosr commented 5 years ago

Done