search

boutproject / BOUT-configs

Configuration scripts for BOUT++
3 stars 6 forks source link

Revert "Fixed bug due to old version of CMake on Marconi" #7

Closed johnomotani closed 2 years ago

johnomotani commented 2 years ago

This reverts commit a5b82a276e2c5db54671ba28ec1195ae26ed0998.

https://github.com/boutproject/BOUT-configs/pull/6#issuecomment-1196963091:

Actually, we don't want to make this change...:

  • The CMake issue has been fixed in BOUT++ on the master branch, and will be fixed on next when master is merged. The marconi branch of BOUT-configs is intended to build the latest release version, which at the moment is 4.4.2 and includes the fix so no workaround is needed here. The workaround disables automatic running of git submodule update ... by CMake, which is normally a good thing to have.
  • Also I don't think we want to set -DBOUT_BUILD_EXAMPLES=ON by default. On master I think it always builds all the examples (which is a waste of time and disk space when they are not needed), and on next I think it is on by default anyway (which makes sense as on next the examples are only configured and not built). If BOUT_BUILD_EXAMPLES=ON is not working by default on next, that's a bug somewhere in BOUT++'s CMake config and needs an issue on BOUT-dev.
ZedThree commented 2 years ago

Oops, sorry, guess I was a bit too hasty!