search

box / box-content-preview

JavaScript library for rendering files stored on Box
https://developer.box.com/docs/box-content-preview
Other
106 stars 113 forks source link

fix(pdf): Move controls layer above popup layer #1499

Closed karelee7 closed 1 year ago

karelee7 commented 1 year ago

The popup annotation layer, which comes before this controls layer in the HTML hierarchy, now has a z-index of 4 due to changes needed for the PDFjs upgrade - because of this, the popup annotation layer was covering this controls layer. This causes the E2E tests in box-annotations to fail. So to resolve this, we need to also bring the controls layer up to a z-index of 4.

Ran this change with the E2E tests for box-annotations locally and it was passing.

karelee7 commented 1 year ago

Thanks for the review @jstoffan ! I also updated the commit message to say fix :)