search

boxen / puppet-dnsmasq

Install the dnsmasq DNS forwarder.
http://boxen.github.com
MIT License
9 stars 29 forks source link

comparison of Float with String failed #8

Closed razic closed 10 years ago

razic commented 10 years ago

Somewhere in the stack trace after running boxen:

Error: comparison of Float with String failed
/opt/boxen/homebrew/Library/Taps/boxen-brews/dnsmasq.rb:28:in `<='
/opt/boxen/homebrew/Library/Taps/boxen-brews/dnsmasq.rb:28:in `install'
/opt/boxen/homebrew/Library/Taps/boxen-brews/dnsmasq.rb:15

Upon further investigation, it appears the MACOS_VERSION constant was recently changed from a Float to a String.

To prevent further issues, instead of assuming the MACOS_VERSION constant is always going to be a Float, I suggest we actually coerce it into a Float before comparison.

orlando commented 10 years ago

:+1:

ocxo commented 10 years ago

Thanks! 1.0.1 released.

razic commented 10 years ago

:cherries: :bomb: