boxen / puppet-dnsmasq

Install the dnsmasq DNS forwarder.
http://boxen.github.com
MIT License
9 stars 29 forks source link

Add localhost as a resolver #9

Closed grosser closed 10 years ago

grosser commented 10 years ago

@createdbypete

/cc @tmcinerney

tmcinerney commented 10 years ago

:+1:

grosser commented 10 years ago

@wfarr mergable ?

grosser commented 10 years ago

pong, merge ?

dgoodlad commented 10 years ago

:-1:

If we're changing this default, it's going to be contentious. Let's start with making it a configurable option (via hiera and a parameterized class), then the default can be changed independently.

grosser commented 10 years ago

What is bad about adding another resolve ?

Now using this fix ...

  # resolve localhost + localhost.com
  # https://github.com/boxen/puppet-dnsmasq/pull/9
  File <| title == "${dnsmasq::config::configdir}/dnsmasq.conf" |> {
    source => undef,
    content => inline_template("<%=
      root = scope.lookupvar('boxen::config::home') + '/repo'
      File.read(root + '/shared/dnsmasq/files/dnsmasq.conf') + File.read(root + '/modules/ours/files/dnsmasq.conf')
    %>")
  }
dgoodlad commented 10 years ago

@grosser taking over that zone completely and arbitrarily is not something I want to do without making it configurable.

grosser commented 9 years ago

now it's configurable, but still cannot add more, would this work ?

dnsmas::add: "address=/localhost.com/127.0.0.1\naddress=/localhost/127.0.0.1"