search

bozdoz / wp-plugin-leaflet-map

Add leaflet maps to Wordpress with shortcodes
https://wordpress.org/plugins/leaflet-map/
GNU General Public License v2.0
140 stars 71 forks source link

php 8.2 compatibility #247

Closed hupe13 closed 4 months ago

hupe13 commented 4 months ago

Hi Bozdoz,

please see https://wordpress.org/support/topic/plugin-is-not-php-8-2-compatible-2/#post-17457554.

I have not any experience in programming class. So I found a solution via Google. I wrote in file class.plugin-option.php line 21: #[AllowDynamicProperties] With this change I don't get any warnings with php 8.2.

bozdoz commented 4 months ago

Looks like it's already fixed but maybe the publish script has failed:

https://github.com/bozdoz/wp-plugin-leaflet-map/commit/c3a3b02494c0a8582896ac36ad5ef406ed739db5

hupe13 commented 4 months ago

Yes, I tested it again with the Github version, it works. Yesterday I tested it with the WordPress version. I have seen the change but not compared it.

bozdoz commented 4 months ago

Yeah I'll have to check why the publish build failed

bozdoz commented 4 months ago

Oh actually looks like I just need a new version image I can look into doing that asap. Maybe tomorrow

hupe13 commented 4 months ago

Thank you very much, works with php 8.3 also.