search

bpakodi / service.nfo.sync

NFO synchronization service for Kodi
GNU General Public License v2.0
0 stars 0 forks source link

nfo that are exported will be processed again at next import, what should we do? #7

Closed bpakodi closed 6 years ago

bpakodi commented 6 years ago

Simply because modified date of the nfo has changed, this file will (should?) be processed at next import.

While not being a "bug", this is definitely something we could improve. Probably by allowing import of a single entry, and by using a temp file to hold the file names to be ignored at next import (only), similarly to issue #4.

However, there is a drawback: import and export scripts could be different. By ignoring next import, we would ignore the script configured for import, too.

bpakodi commented 6 years ago

Drawback is bypassed, as we now have only one script running for both import and export

bpakodi commented 6 years ago

It has to be noticed that the import right after export of a given file will be harmless: nfo will not be saved again, as contents are identical => non-blocking issue

For this reason, setting priority to low

bpakodi commented 6 years ago

Use case where this can be a bug: the script applied on export generates tags are not yet in NFO, for example because the script has been modified since previous import. The NFO will be correctly patched to have these tags, but they won't be reflected in Kodi, as they were not in the NFO at the time of import. So, in this case, we should force a re-import (of the single entry, if possible) => this is a bug (low priority, but a bug)

bpakodi commented 6 years ago

should be addressed by #15

bpakodi commented 6 years ago

15 closed: 2087741be7374494f2d911baaa0ac36e249f979b

bpakodi commented 6 years ago

still need to check if this is still aplicable

bpakodi commented 6 years ago

solved by: 3dce96e650e8f6a90167e164771fe6cf5c7171a0 it has to be noticed a minor drawback: the ImportSingleTask, involved when NFO modified => refresh, will not have the import resume point saved. For this reason, the NFO will be considered at next ImportAll; but it will be ignored, because contents will be identical. So basically only an issue about what is displayed to the user, and one we cannot avoid, due to limitations with Kodi core logic.