search

bpearson / atom-phpcs

PHP CodeSniffer package for Atom editor
MIT License
6 stars 1 forks source link

multiple phpcs processes spawned #30

Open nosilver4u opened 7 years ago

nosilver4u commented 7 years ago

There seems to be some sort of problem where this package is spawning multiple phpcs requests when saving a file. It seems to be related to the length of the file, as short files only spawn a few and finish quickly, whereas larger files (7000+ lines) might spawn 16+ instances, and take quite some time to complete the parsing as a result.

bpearson commented 7 years ago

Hmm I am not seeing this, could this possibly the number of tabs open over the length of the file?

miklb commented 7 years ago

I'm getting Error running phpcs and multiple php processes using more than 90% CPI. Maybe related to latest version of phpcs installed with homebrew?

I have phpcs 2.8.1 installed. Atom version 1.15, linter-phpcs 1.6 macOS 10.12.4

Let me know if I can provide any additional information or suggestions. Cheers.

bpearson commented 7 years ago

Did you change the path to match the homebrew install? Also check that its not linter-phpcs spawning the processes.

miklb commented 7 years ago

I sincerely apologize, I do believe it is linter-phpcs. Confused the 2 packages.

nosilver4u commented 7 years ago

Following up on my original report, I was able to get back to the "normal" behavior of 1 phpcs process spawning only after completely closing (quitting) Atom, and re-opening my project. I haven't seen the behavior resurface yet, but I'll try to see if I can figure out what triggered it.