bpg / terraform-provider-proxmox

Terraform Provider for Proxmox
https://registry.terraform.io/providers/bpg/proxmox
Mozilla Public License 2.0
876 stars 140 forks source link

Explicitly assign an IP address to a network interface in LXC #377

Open kam193 opened 1 year ago

kam193 commented 1 year ago

Is your feature request related to a problem? Please describe. When I create a container with multiple network interfaces, they all need an IP configuration. Currently, this can be achieved by multiple ip_config blocks in the initialization block. However, they are assigned to the network interfaces using just the order in the configuration file (if I read the code correctly).

Describe the solution you'd like I'd suggest moving the IP configuration inside the network interface block, and deprecate using it in the initialization section.

Describe alternatives you've considered

Additional context If I change the order of interfaces or ip configurations, terraform recognizes this as a change and try to reconfigure interfaces, using inadequate IPs.

marksie1988 commented 1 year ago

I also think that moving this to the network config would be best, if its under there you know 100% that it would be applied to the interface that it is with. currently its a guess as to which interface will get the IP Config.

bpg-autobot[bot] commented 7 months ago

Marking this issue as stale due to inactivity in the past 180 days. This helps us focus on the active issues. If this issue is reproducible with the latest version of the provider, please comment. If this issue receives no comments in the next 30 days it will automatically be closed. If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

bpg-autobot[bot] commented 1 week ago

Marking this issue as stale due to inactivity in the past 180 days. This helps us focus on the active issues. If this issue is reproducible with the latest version of the provider, please comment. If this issue receives no comments in the next 30 days it will automatically be closed. If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!