search

bpmn-io / bpmn-js-element-templates

The element template extension for bpmn-js
MIT License
5 stars 3 forks source link

Field length error message #95

Closed holygeek00 closed 4 months ago

holygeek00 commented 4 months ago
Screenshot 2024-05-08 at 13 50 04 Screenshot 2024-05-08 at 14 00 46

Related to https://github.com/camunda/camunda-modeler/issues/4207

holygeek00 commented 4 months ago

Requires https://github.com/camunda/camunda-modeler/issues/4207

nikku commented 4 months ago

@holygeek00 @marstamm What do you think about the proposed error message? What I liked about the old one is that we do proper casing <Name of field> must be. Now it reads <Name of Field> Field ... which I find odd.

nikku commented 4 months ago

Cf. also @barmac's prior investigations - https://github.com/camunda/camunda-modeler/issues/4207#issuecomment-2046701530.

Could be worth do do a poll in the team channel to quickly agree on a direction to take.

marstamm commented 4 months ago

I agree, the naming is odd. We should either make it short and precise ("Use at least X Characters") or clean up the error message ("\<PropertyName> must be at least X Characters"). The additional field is redundant