Labels auto-move unintentionally

nikku commented 5 years ago

Describe the Bug

Our automatic label adjustment is meant to help people by putting labels in appropriate, free spots, it should not introduce additional noise as seen in the following screen casts:

foo_1

Steps to Reproduce

Open label-move.bpmn
Move Choose Recipe task to second participant
See how the label changes its position

Expected Behavior

[ ] Label does not adjust its position, unless required by incoming / outgoing connections.

Environment

Please complete the following information:

Browser: [e.g. IE 11, Chrome 69]
OS: [e.g. Windows 7]
Library version: v3.3.1, master

nikku commented 5 years ago

Root Cause Analysis

As part of our usual operations we do the following:

Move shape (choose recipe) is triggered
MoveHelper moves the shape
MoveHelper triggers layout of incoming and outgoing connection
AdaptiveLabelPositioningBehavior picks up the connection.layout event and moves the labels
...
ReplaceConnectionBehavior removes the sequence flows that are now forbidden
Labels remain in new, odd positions

nikku commented 5 years ago

Cf. failing test case.

bpmn-io / bpmn-js

Labels auto-move unintentionally #992