The `decimal()` FEEL expression does not appropriately round - Githubissues

bpmn-io / form-js

View and visually edit JSON-based forms.

https://bpmn.io/toolkit/form-js/

Other

419 stars 109 forks source link

The `decimal()` FEEL expression does not appropriately round #1229

Closed Skaiir closed 3 months ago

Skaiir commented 3 months ago

Describe the Bug

decimal(value, n) should round using bankers round, which it currently does not. This is to be fixed in feelin.

Steps to Reproduce

create a number field
render that number in a text view using decimal(numberFieldKey, 2)
set the number to various numbers and notice the rounding behavior doesn't fit the bankers rounding scheme

Expected Behavior

bankers rounding should happen consistently (ie 1.5 -> 2, 2.5 -> 2, -2.5 -> -2, ect...)

Breakdown

[x] https://github.com/nikku/feelin/issues/77
[x] release feelin
[x] integrate feelin into form-js

Skaiir commented 3 months ago

Closed via https://github.com/bpmn-io/form-js/pull/1236