bpmn-io / form-js

View and visually edit JSON-based forms.
https://bpmn.io/toolkit/form-js/
Other
419 stars 109 forks source link

Add implicit keyboard binding / migrate to diagram-js@15 #1269

Closed vsgoulart closed 1 week ago

vsgoulart commented 2 months ago

This updates the library to diagram-js@15 which ships breaking changes.

BREAKING CHANGES:

Related to https://github.com/bpmn-io/diagram-js/pull/662

barmac commented 2 weeks ago

Diagram-js@15 has been released. To support the migration, I will make sure this PR is mergable.

barmac commented 2 weeks ago

Ready to review @Skaiir @vsgoulart

barmac commented 2 weeks ago

Since I am only contributing here, please merge when you're ready.

nikku commented 1 week ago

I could not not break it either, and the integration speaks to the simplicity of this thing. Great job :clap:

Added two comments https://github.com/bpmn-io/form-js/pull/1269#discussion_r1848393961, we probably cannot follow up on those, as we don't use the canvas, right?

barmac commented 1 week ago

Indeed, there is no canvas in form-js :(