Open philippfromme opened 1 week ago
cc @bastiankoerber
What about if we shorten this to "Learn FEEL", "Try co-pilot"?
Why the external launch link, when the thing clearly is a link?
If we merge this as is, this means that any @bpmn-io/properties-panel
user is nudged to try out FEEL copilot, regardless if they use Camunda or not. While this may sound OK from the business perspective, this is still an MIT-licensed open source library. From that perspective, I'd rather expect the link to be plugged somehow in Camunda products instead of making it part of the upstream library. While we already have a link to the documentation in the source code, I think it's rather more stable than a link to an experimental project.
TLDR: My suggestion is to make it pluggable, and implement the link downstream.
Also note that the link in its current form does not currently contain any UTM parameters, and with the current approach we cannot fix it easily as for each adjustment a change in this library needs to be integrated downstream.
Alternative: Move the popup editor out (make it a Camunda extension), and hence be free on how we integrate Camunda docs links there. Given past discussions on the editor, that could work, too.
I was expecting the pushback. I just wanted to avoid having to do a major refactoring for a single link. 🙈
What about if we shorten this to "Learn FEEL", "Try co-pilot"?
"Learn FEEL" works for me! For Copilot, I think there are a couple of things to to figure out.
Why the external launch link, when the thing clearly is a link?
The design team decided to use the launch icon to indicate when a link takes you to an external site. (I personally tend to interpret it as "this link will open in a new tab", but I've just done some research and apparently not everyone shares that interpretation.)
Proposed Changes
Adds a link to promote the new FEEL Copilot.
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/sr
toolCloses {LINK_TO_ISSUE}
orRelated to {LINK_TO_ISSUE}