brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Use scrollTop instead of scrollIntoView for #2130 #2224

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by jasonsanjose Monday Dec 10, 2012 at 23:04 GMT Originally opened as https://github.com/adobe/brackets/pull/2325


Explicitly set scrollTop instead of relying on the DOM Element scrollIntoView() to determine scroll position. Fix for #2130.


jasonsanjose included the following code: https://github.com/adobe/brackets/pull/2325/commits

core-ai-bot commented 3 years ago

Comment by redmunds Tuesday Dec 11, 2012 at 01:07 GMT


Done with initial code review.

Works great! Just a suggestion about cleaning up code.

core-ai-bot commented 3 years ago

Comment by redmunds Tuesday Dec 11, 2012 at 02:46 GMT


Looks good. Merging.