search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] [cmv4] Simplify and update soft tab handling for multiple selections #6429

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by njx Thursday Mar 06, 2014 at 02:09 GMT Originally opened as https://github.com/adobe/brackets/pull/7103

For #7002. See the Google Group thread on soft tabs for more information on the new behavior. I'll add a few comments inline to explain some of the changes.

njx included the following code: https://github.com/adobe/brackets/pull/7103/commits

core-ai-bot commented 3 years ago

Comment by redmunds Thursday Mar 06, 2014 at 17:39 GMT

Done with review. Only jsdoc comment.

core-ai-bot commented 3 years ago

Comment by njx Thursday Mar 06, 2014 at 17:50 GMT

@redmunds - fixed the comment, ready for re-review. Does the new behavior feel okay to you in general?

core-ai-bot commented 3 years ago

Comment by redmunds Thursday Mar 06, 2014 at 19:02 GMT

@njx For a single cursor, the new soft tab behavior works great.

For multiple cursors, I think the behavior you implemented makes sense. A similar case that comes to mind is using Ctrl+left/right-arrow -- every cursor is most likely going to move a different number of chars. But, user has option of using Ctrl key or not, so no need to change any behavior there.

core-ai-bot commented 3 years ago

Comment by redmunds Thursday Mar 06, 2014 at 19:03 GMT

Looks good. Merging.