bradbell / at_cascade

Cascading Dismod_at Analysis From Parent To Child Regions
https://at-cascade.readthedocs.io
4 stars 3 forks source link

Add csv.simulate example in R #4

Closed garland-culbreth closed 10 months ago

garland-culbreth commented 10 months ago

The example creates input files for the same simulation as simulate_xam.py but stops before running the simulate commands, for users who might want to use R to create input files before running the simulation with the python commands.

bradbell commented 10 months ago

This example breaks one of my documentation rules. To be specific, all of the examples must run as automated tests. This ensures that as the package changes, all the examples still work see "... Each documentation section should include a simple example that automatically checks for correctness.” below Verification on https://www.seanet.com/~bradbell/software.html#verification

The script https://github.com/bradbell/at_cascade/blob/master/bin/check_all.sh runs all the at-cascade automated tests.

bradbell commented 10 months ago

Are you planning to change this example, and check_all.sh so that it is an automated that that runs in the context of this project. If not, please close this pull request.

garland-culbreth commented 10 months ago

Eventually, but I'll open a new PR once it's updated to comply with this.

bradbell commented 10 months ago

You can use this pull request and re-open it.