search

bradfrost / ish.

ish. is yet another viewport resizer
731 stars 74 forks source link

refactored init.js #10

Closed acconrad closed 11 years ago

acconrad commented 11 years ago

Liked this plugin but found some easy-win optimizations I decided to work on:

-removed erroneous / unnecessary variable declarations -DRYed up some repeated functions -added constants (e.g. SMALL, LARGE) -switch to vanilla Javascript for computationally-intensive functions -general code cleanup for readability

bradfrost commented 11 years ago

Hey Adam, Really appreciate all the refactored code. We're currently in the process on bringing over a lot of the functionality from Pattern Lab http://demo.pattern-lab.info/ over to ish, so I'm going to hold off merging this code.

Once the second version is launched, I'd love to have you take a look at it and see what can be cleaned up. Regardless, I'll keep this is mind once I bring over the other stuff.

Thanks so much for your help!