search

bradfrost / ish.

ish. is yet another viewport resizer
731 stars 74 forks source link

(For feedback only) Ishlet, the bookmarklet version of ish. #13

Closed joemcgill closed 4 years ago

joemcgill commented 10 years ago

Hey Brad,

Seeing you demo ish. yesterday reminded me that I never got the bookmarklet working with your 2.0 changes. I did a quick update and have everything working with a few caveats, which is why I figured I'd get some feedback.

  1. Are you interested in adding this to the ish. project or would you rather me make it it's own thing (cool either way)?
  2. If you are interested in including this with ish. proper—my current implementation of the index page exists for the sole purpose of giving you an easy way to drag the bookmarklet to your bookmarks bar but requires PHP, so the landing page would have to run off a LAMP server and not a github.io page. Any worries there?
  3. Right now, I've got the bookmarklet linking to the ish. css/js files from your demo (bradfrostweb.com/demo/ish/) which may be fine if you're including the bookmarket as a part of the overall ish. project, otherwise I'd probably want to get those files somewhere else. Any feedback there would be welcome.

Any additional thoughts welcome.

joemcgill commented 10 years ago

BTW: you can see a quick demo of this code here: http://projects.joemcgill.net/ish./ishlet/

ghost commented 10 years ago

This is awesome.

bradfrost commented 10 years ago

Hey @joemcgill! Thanks for the update on ishlet. To answer your questions:

  1. I think it would be awesome to have it rolled into the main version if that's cool with you. Would it just be a little button in the dashboard that says "drag into your bookmarks bar" or something?
  2. Currently ish is run on my own server, not Github's, so that shouldn't be a problem
  3. If it's all happening under on roof, then it should be fine to have those files pointing to my server.

So what do we need to do to integrate these?

joemcgill commented 10 years ago

Off the top of my head I could see this working a couple different ways:

  1. We could build the bookmarklet button right into the ish UI, the only downside being that it would probably need explanation (tooltip maybe?).
  2. Include a button on the main ish. demo page (http://bradfrostweb.com/demo/ish/) That people could drag to their bookmarks bar.

Thoughts?

bradfrost commented 10 years ago

Maybe including a button on the demo page would be a good idea!

Brad Frost http://bradfrostweb.com http://twitter.com/brad_frost

On Sun, Apr 13, 2014 at 6:05 PM, Joe McGill notifications@github.comwrote:

Off the top of my head I could see this working a couple different ways:

  1. We could build the bookmarklet button right into the ish UI, the only downside being that it would probably need explanation (tooltip maybe?).
  2. Include a button on the main ish. demo page ( http://bradfrostweb.com/demo/ish/) That people could drag to their bookmarks bar.

Thoughts?

— Reply to this email directly or view it on GitHubhttps://github.com/bradfrost/ish./pull/13#issuecomment-40321471 .

joemcgill commented 4 years ago

👋 Hi Brad. Just doing a little GitHub maintenance.