braice / MuMuDVB

A DVB IPTV streaming software
http://mumudvb.braice.net/
GNU General Public License v2.0
219 stars 133 forks source link

Missing closing files #280

Open ryancaicse opened 2 years ago

ryancaicse commented 2 years ago

fclose (conf_file); should be put before Line 601 and 609? https://github.com/braice/MuMuDVB/blob/9beba0dbfa07f49d0dd894f57fae2a4cc87613e8/src/mumudvb.c#L378-L691

braice commented 2 years ago

Hello

Between 601 and 609 is some reading part of the configuration file. If you speak about failure condition, I know it is not perfect but the OS will free the file descriptor when the process dies. Unfortunately there is no raise in C "The C library function void exit(int status) terminates the calling process immediately. Any open file descriptors belonging to the process are closed and any children of the process are inherited by process 1, init, and the process parent is sent a SIGCHLD signal."

Brice

On Thu, Dec 23, 2021 at 2:30 PM ryancaicse @.***> wrote:

fclose (conf_file); should be put before Line 601 and 609?

https://github.com/braice/MuMuDVB/blob/9beba0dbfa07f49d0dd894f57fae2a4cc87613e8/src/mumudvb.c#L378-L691

— Reply to this email directly, view it on GitHub https://github.com/braice/MuMuDVB/issues/280, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACRIDYAHOPABNXTA6JT5QTUSMP7DANCNFSM5KUZHQIQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>