Closed interstar closed 5 years ago
Ah, thanks for reporting this! I've been using JDK 8 for a while now; I know we need to update our dependencies to work with more modern javas; I'll take a look at this in a few days.
Turned out to be easier than I feared! Closed by b6a40c27; I'm now able to run it on both java 8 and 11
To be honest, I'm still having a problem :
Error occurred during initialization of boot layer
java.lang.module.FindException: Module java.xml.bind not found
Exception in thread "Thread-1" clojure.lang.ExceptionInfo: Subprocess failed {:exit-code 1}
at clojure.core$ex_info.invokeStatic(core.clj:4617)
at clojure.core$ex_info.invoke(core.clj:4617)
at leiningen.core.eval$fn__4134.invokeStatic(eval.clj:264)
at leiningen.core.eval$fn__4134.invoke(eval.clj:260)
at clojure.lang.MultiFn.invoke(MultiFn.java:233)
at leiningen.core.eval$eval_in_project.invokeStatic(eval.clj:366)
at leiningen.core.eval$eval_in_project.invoke(eval.clj:356)
at leiningen.repl$server$fn__5864.invoke(repl.clj:244)
at clojure.lang.AFn.applyToHelper(AFn.java:152)
at clojure.lang.AFn.applyTo(AFn.java:144)
at clojure.core$apply.invokeStatic(core.clj:646)
at clojure.core$with_bindings_STAR_.invokeStatic(core.clj:1881)
at clojure.core$with_bindings_STAR_.doInvoke(core.clj:1881)
at clojure.lang.RestFn.invoke(RestFn.java:425)
at clojure.lang.AFn.applyToHelper(AFn.java:156)
at clojure.lang.RestFn.applyTo(RestFn.java:132)
at clojure.core$apply.invokeStatic(core.clj:650)
at clojure.core$bound_fn_STAR_$fn__4671.doInvoke(core.clj:1911)
at clojure.lang.RestFn.invoke(RestFn.java:397)
at clojure.lang.AFn.run(AFn.java:22)
at java.base/java.lang.Thread.run(Thread.java:834)
That's after checking out the latest version that contains the ["--add-modules" "java.xml.bind"] in project.clj
Maybe related to https://stackoverflow.com/questions/52502189/java-11-package-javax-xml-bind-does-not-exist
Do you have to add the dependency in Maven explicitly in the project.clj file. As I understand javax.xml.bind is now split into several libs.
Ah, I see. Okay, I'll try another fix later today -- I think we can just fully replace the one thing that's using java.xml.bind.
Okay, pushed some changes & things seem to be working now for me under java 11.
Right. Yep, now starts.
Though going to 5555 first, just tells me I should compile the ClojureScript files with figwheel. But this bug seems fixed.
cheers
Though going to 5555 first, just tells me I should compile the ClojureScript files with figwheel. But this bug seems fixed.
Hm, strange; running (start! 5555)
should also start figwheel; are
there any other error messages?
Actually it seemed to just be taking its time. When I went back to the tab a few minutes later, it was working.
Looks cool! Well done. I'll start looking into the code soon.
When I try to follow the quickstart instructions on https://github.com/braidchat/braid/blob/master/docs/dev/getting-up-and-running-in-development.md
I get :
My Java version is :