Issue: #135 Add a user administration page (for admins only)

braidchat / braid

Braid is a team-chat app with a novel UI that leads to better conversations.

http://www.braidchat.com/

Other

923 stars 53 forks source link

Issue: #135 Add a user administration page (for admins only) #206

Closed GeoDoo closed 4 years ago

GeoDoo commented 4 years ago

[x] Add a menu item in the admin menu
[x] Ideally menu item should be a hook
[x] Create a module for the page
[x] Read users from state
[x] List of users with name and "make user an admin" button (as first step)
[ ] The page should list of users in a table (with their name, last-sign in) and buttons to remove user or make the user an admin.
[ ] Later, add the ability to bulk invite users.

jamesnvc commented 4 years ago

Looking good! I just pushed a change to master (946fe28e) that makes admin-header-views a hook. You should now be able to remove your change to header.cljs & "register" the header item in the same manner as the bots module now does.

GeoDoo commented 4 years ago

Cool, thanks for that. I tried in the beginning to make the changes you made but I couldn't do it 😄 Check now! It should be ok I guess.

jamesnvc commented 4 years ago

Nice! Btw, one other thing to note: currently, although the link only shows up if the user is an admin, the user can still manually type the url in to get to that page. The users-page-view should probably also check if the user viewing is an admin for the current group -- see braid.bots.client.views.bots-page for an example of how we do that.

GeoDoo commented 4 years ago

😄 Yes, I have noticed that already. A small step at a time! 😄 I will check that out too, thanks for the guidance. 🎉

jamesnvc commented 4 years ago

Hey @GeoDoo! Just so this PR doesn't bit-rot away, I'm going to clean up some little things and merge it now.

Please feel free to open up a new PR to add more enhancements 😄

GeoDoo commented 4 years ago

Cool thanks @jamesnvc sorry for that, busy weeks 😄