search

braidchat / braid

Braid is a team-chat app with a novel UI that leads to better conversations.
http://www.braidchat.com/
Other
923 stars 53 forks source link

Provide a means for braid consumers to stop the application #222

Closed cch1 closed 3 years ago

cch1 commented 3 years ago

When consuming braid in another application, the ability to stop braid is valuable. Without this PR, the dev-src path needs to be on the classpath but that is challenging with both lein and Clojure CLI when braid is a dependency.

jamesnvc commented 3 years ago

Nice, thanks! While we're doing this change, we can also get rid of the {:port port} argument to mount/start -- just passing the port to mount/with-args should be sufficient, I think.

cch1 commented 3 years ago

I'm not that familiar (yet) with the syntax of mount, so I'll have to leave that to you. I did start down a related path of having the mount calls all be in braid.core (none in braid.dev.core) but in the dev environment you clearly need to apply an exception to the components to be started. I wasn't sure how you might want to achieve that... Still, DRYing up the mount start/stop into just braid.core seems like a good goal for those developing using braid.dev.core. My development approach does not use braid.dev.core so I don't have a vested interest in making that change.

jamesnvc commented 3 years ago

I did start down a related path of having the mount calls all be in braid.core (none in braid.dev.core) but in the dev environment you clearly need to apply an exception to the components to be started

I was also thinking of that, but as you say, dev wants to apply some exceptions, so this is probably fine for now.

I will merge and make that little tweak. Thanks!