search

braidchat / braid

Braid is a team-chat app with a novel UI that leads to better conversations.
http://www.braidchat.com/
Other
923 stars 53 forks source link

Aws credentials provider support #227

Closed cch1 closed 3 years ago

cch1 commented 3 years ago

This PR provides a late binding for AWS credentials -essential for AWS role-based credentials and STS.

Despite mimicking the AWSCredentialsProvider api, this PR does not add a dependency on the AWS SDK. At some future time it would probably be a good idea to replace the custom work in braid.lib.aws in favor of the SDK approach but I'm not tackling that here.

jamesnvc commented 3 years ago

At some future time it would probably be a good idea to replace the custom work in braid.lib.aws in favor of the SDK approach

I believe we specifically removed the AWS SDK previously. I don't like pulling in a dependency that large just to wrap some HTTP API calls.

jamesnvc commented 3 years ago

I generally like to have whitespace-only changes in their own commits, but I'm okay if that's a pain to separate them out.

cch1 commented 3 years ago

Understood and agreed. Unfortunately those changes are made automatically by clojure-mode in emacs which tries to adhere to the style guide. I appreciate your flexibility in accepting this PR with those changes embedded within.

cch1 commented 3 years ago

At some future time it would probably be a good idea to replace the custom work in braid.lib.aws in favor of the SDK approach

I believe we specifically removed the AWS SDK previously. I don't like pulling in a dependency that large just to wrap some HTTP API calls.

That was my assumption. Worth mentioning that the new SDK has documented support for pulling in subsets of the entire sdk....