fix: Setting offset breaks "centered"

brainhubeu / react-carousel

A pure extendable React carousel, powered by Brainhub (craftsmen who ❤️ JS)

https://brainhub.eu/

MIT License

1.07k stars 164 forks source link

fix: Setting offset breaks "centered" #593

Closed mcmxcdev closed 4 years ago

mcmxcdev commented 4 years ago

Closes #394.

After a long discussion in the issue, we decided to change from usage of padding to margin to work around spacing issues with box-sizing: border-box, which could be set by css resets or css frameworks by default.

IssueHunt Summary

### Referenced issues This pull request has been submitted to: - [#394: Setting offset breaks 'centered'](https://issuehunt.io/repos/116013398/issues/394) ---

mcmxcdev commented 4 years ago

Unfortunately I didn't know about the branch naming conventions. Should I do the PR again from a correct branch name or can this be ignored?

piotr-s-brainhub commented 4 years ago

@mhatvan

I opened https://github.com/brainhubeu/react-carousel/pull/594 instead because only for the main repo, it's possible to build a testing environment. It's according to the workflow.