search

brainpicture / hashlib

lib for node which makes hashes
nodejs.ru
165 stars 35 forks source link

Fix for #25 - Not compiling on Node 0.6 (actually happened since node 0.5.5) #26

Closed ovaillancourt closed 12 years ago

ovaillancourt commented 12 years ago

Fix for issue #25

[hashlib.cc] - Including node.h instead of ev.h and eio.h. node.h includes these files correctly, which might move around from one version of node to the other. (So basically, node.h should be included instead of specifically including ev and eio.) [README.md, makefile, package.json, test.js] - Changing the '/build/default/hashlib' path to '/build/Release/hashlib'. Node-waf, starting from node 0.5.5 uses the Release environment by default.

ovaillancourt commented 12 years ago

As a head's up, these changes break compatibility with anything lower than node 0.5.5 because of the default/Release environment change. Oleg, you might want to adjust the current/upcoming packages' node version dependencies accordingly on npm. (Forgot to do that.)

See next commit.

ovaillancourt commented 12 years ago

Ok, just tweaked the package.json according to my previous comment.

erik-megarad commented 12 years ago

+1 - please merge this asap!

ovaillancourt commented 12 years ago

For those who need to integrate this asap with their stuffs, use the following command :

npm install https://github.com/Hiverness/hashlib/tarball/compat_fix_node_0_6_X

It's only temporary though, I'm gonna remove that as soon as Oleg pushes this to npm.

afanasy commented 12 years ago

+1

brainpicture commented 12 years ago

Now should compile properly.

ovaillancourt commented 12 years ago

Alrighty, I'll close the pull request! Thanks!