Your library is great and I already use it in a project. Unfortunately it has a little (?) drawback: it uses global javascript functions/objects, which names might conflict with other libraries.
I'm talking about formatter, linebreak and LinkedList.
An easy solution is to move them into one namespace, which should make conflicts less likely.
I have already done the job for my projects and will send you a pull request, so you could use it if you want to. I can squash the commits into one, if you prefer to.
I moved formatter to Typeset.formatter, linebreak to Typeset.linebreak and LinkedList to Typeset.LinkedList.
If you have questions or issues with that, please contact me.
David
MacDada
commented
11 years ago
Hi!
Your library is great and I already use it in a project. Unfortunately it has a little (?) drawback: it uses global javascript functions/objects, which names might conflict with other libraries.
I'm talking about
formatter,linebreakandLinkedList.An easy solution is to move them into one namespace, which should make conflicts less likely.
I have already done the job for my projects and will send you a pull request, so you could use it if you want to. I can squash the commits into one, if you prefer to.
I moved
formattertoTypeset.formatter,linebreaktoTypeset.linebreakandLinkedListtoTypeset.LinkedList.If you have questions or issues with that, please contact me. David