search

bramstein / typeset

TeX line breaking algorithm in JavaScript
BSD 2-Clause "Simplified" License
998 stars 74 forks source link

Global library functions moved to Typeset namespace #5

Closed MacDada closed 11 years ago

MacDada commented 11 years ago

Hi!

Your library is great and I already use it in a project. Unfortunately it has a little (?) drawback: it uses global javascript functions/objects, which names might conflict with other libraries.

I'm talking about formatter, linebreak and LinkedList.

An easy solution is to move them into one namespace, which should make conflicts less likely.

I have already done the job for my projects, so you could use it if you want to. I can squash the commits into one, if you prefer to.

I moved formatter to Typeset.formatter, linebreak to Typeset.linebreak and LinkedList to Typeset.LinkedList.

If you have questions or issues with that, please contact me. David

bramstein commented 11 years ago

Thanks a lot for the pull request. That must have been a lot of work. I'll need to go through it, but I'm currently working on a new project that is meant to replace typeset so this will unfortunately will have lower priority.