bramus / react-native-maps-directions

Directions Component for `react-native-maps`
MIT License
1.25k stars 197 forks source link

`Error: Element type is invalid` with react-native-maps v1.0.0 #195

Closed ptreitler closed 2 years ago

ptreitler commented 2 years ago

After updating to v1.0.0 of react-native maps I got the following error:

 ERROR  Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.

Check the render method of `MapViewDirections`.
ptreitler commented 2 years ago

Seems to be a change with the exports of react-native-maps. Here's a patch that fixes the error for me:

diff --git a/node_modules/react-native-maps-directions/src/MapViewDirections.js b/node_modules/react-native-maps-directions/src/MapViewDirections.js
index ac08d73..f04ef10 100644
--- a/node_modules/react-native-maps-directions/src/MapViewDirections.js
+++ b/node_modules/react-native-maps-directions/src/MapViewDirections.js
@@ -1,6 +1,6 @@
 import React, { Component } from 'react';
 import PropTypes from 'prop-types';
-import MapView from 'react-native-maps';
+import { Polyline } from 'react-native-maps';
 import isEqual from 'lodash.isequal';

 const WAYPOINT_LIMIT = 10;
@@ -305,7 +305,7 @@ class MapViewDirections extends Component {
        } = this.props;

        return (
-           <MapView.Polyline coordinates={coordinates} {...props} />
+           <Polyline coordinates={coordinates} {...props} />
        );
    }
nicolasdevienne commented 2 years ago

@bramus the fix seems not to be included in the last version 1.1.0 ... When I install the package thanks to yarn add react-native-maps-directions, the fix is missing from file src/MapViewDirections.js ...

Judefabi commented 2 years ago

same here @nicolasdevienne , however, if you navigate to /node_modules/react-native-maps-directions/src/MapViewDirections.js and edit mapviewdirections.js with the code above it work. when you build however it restores the default code and it will fail again

nicolasdevienne commented 2 years ago

hi @Judefabi ! A fix has been merged : https://github.com/bramus/react-native-maps-directions/pull/196 but does not appear when we install the package...

bramus commented 2 years ago

I’ll push a new release later today.

bramus commented 2 years ago

Released as 1.9.0