search

brandondahler / Data.HashFunction

C# library to create a common interface to non-cryptographic hash functions.
MIT License
255 stars 42 forks source link

Support for .NET 3.5 #28

Closed witcher112 closed 7 years ago

witcher112 commented 8 years ago

Hello,

I've added a support for .NET 3.5 in Data.HashFunction projects. Currently only in Data.HashFunctions.Core, Data.HashFunctions.Interfaces, Data.HashFunctions.xxHash

DataHashFunctionBot commented 8 years ago

Can one of the admins verify this patch?

brandondahler commented 8 years ago

Biggest problem with this request is that the CI process was not taken into account. Currently the project is set up to build via CI.msbuild, which will produce all of the NuGet packages that need to be pushed.

With CI in mind, we'll probably want to remove the explicit *.NET35.csproj files and instead follow the setup for NET40 (minus the Net40Async packages).

If you'd like to take a crack at it, feel free to ask any questions you might have. You'll know you have it right when you can run the following command from the package manager console successfully & "C:\Program Files (x86)\MSBuild\12.0\Bin\msbuild.exe" CI.msbuild

Otherwise I'll get to it in my spare time at some point.

brandondahler commented 7 years ago

At this point, I believe I'm going to deprecate support for frameworks older than net45 for efficiency, code cleanliness, and build system purposes.

I have decrypted the code signing key in the master branch so that, by the nature of OSS, people can modify and build their own, forked version if they choose without disrupting the Strong Name signing validations.