search

brandondahler / Data.HashFunction

C# library to create a common interface to non-cryptographic hash functions.
MIT License
255 stars 42 forks source link

Potential .NET Core Migration #29

Closed antoinne85 closed 7 years ago

antoinne85 commented 7 years ago

My company is currently considering porting some of our projects over to .NET Core and your MurmurHash library (and its dependencies) are in use all over the place (requiring us to either swap out the hashing algorithm in use or to migrate your libraries to move forward).

Do you have any plans to prepare these libraries for use with .NET Core/Standard? If not, would you be open to a PR that does so?

antoinne85 commented 7 years ago

I'll add that according to https://docs.microsoft.com/en-us/dotnet/standard/net-standard, it looks like a migration would still be able to support folks on .NET Framework 4.5 (the current target framework, if I've not missed anything in examining the repository). That'd put this project on .NET Standard 1.0.

brandondahler commented 7 years ago

See #24 . I have been working on v2.0 for a little while now -- that will implement the minimal netstandard versions based on the requirements of each hash function (netstandard1.1 for most, 1.3 for HashAlgorithmWrapper for instance). There is a pre-release build of 2.0.0 based on the DotNetCore branch, but there are a number of API changes that version does not have quite yet.

I'd welcome any pull requests, but if you plan on updating any .NET core related things, you'll want to branch off of the DotNetCore branch.

brandondahler commented 7 years ago

Closing as duplicate of #24