brandonmp / gatsby-source-google-sheets

A GatsbyJS plugin that pulls nodes from rows in a Google Sheet.
90 stars 32 forks source link

Determine column data type by all cells in given column #19

Closed MartinNuc closed 5 years ago

MartinNuc commented 6 years ago

This solves issue https://github.com/brandonmp/gatsby-source-google-sheets/issues/18 with inconsistent data types with mixed data.

Solution:

  1. First it goes through all data and tries to define a data type for each column.
  2. After it goes through all data types and it parses values based on data type from the previous step.
drewatk commented 6 years ago

@brandonmp Any chance we can get this merged in?

MartinNuc commented 5 years ago

Any comments regarding review? It has been 7 months already.

drewatk commented 5 years ago

Hey Martin, thanks for reminding me about this I am now a contributor to this project. I'll take a closer look at this soon and evaluate what we need for an updated release soon. Thanks!