search

brandonshin / slackbot-workout

A fun hack that gets Slackbot to force your teammates to work out!
MIT License
563 stars 128 forks source link

Include a Dockerfile and change configuration strategy to use a JSON file #28

Open bobbytables opened 9 years ago

bobbytables commented 9 years ago

This changes around how configuration is loaded, pulling from the JSON file for everything.

This is done to enable Docker containerization easily. By mounting a config.json file in the container on start, and setting an ENV variable pointing to that file. We can easily load in configuration to the container on start.

We're using this fork at Namely right now and it's working great. Super easy to deploy.

@brandonshin - I'm happy to add you to the slackbots docker organization on hub.docker.com

bobbytables commented 9 years ago

@brandonshin - What do you think of this approach ? Full Disclosure, I am not a python dev. :smiling_imp:

brandonshin commented 9 years ago

taking a look at it 👍 Thanks for the PR, making it easy to onboard is definitely a priority. I'll reach out to you to discuss a couple points before pulling it in

bobbytables commented 9 years ago

@brandonshin - Looking forward to your feedback.