search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.99k stars 2.35k forks source link

Blocked Autoplay ignores User input and breaks playback/-lists #18369

Open RizzeKnight opened 3 years ago

RizzeKnight commented 3 years ago

(Please note: not tested on Android) Please note issues that are / seem to / might be related, at the bottom under 'Misc'.

PLEASE USE THE TEMPLATE BELOW TO PROVIDE INFORMATION ABOUT THE ISSUE. INSUFFICIENT INFO WILL GET THE ISSUE CLOSED. IT WILL ONLY BE REOPENED AFTER SUFFICIENT INFO IS PROVIDED-->

Description

With Autoplay set to 'blocked', many (yet not all) sites are

  1. not even playing any media (audio/video) based on user input, at least not properly, i.e. when the user clicks 'Play', it is simply ignored (or cancelled).
  2. also blocked from 'go to next file', in playlists.

Steps to Reproduce

EDIT: added telling example on radiorecord.ru.

  1. Ignoring user input: A. Go to an affected site (YT for example is NOT affected by this), for example radio.net, or vimeo.com. Twitch is another funky example, as is radiorecord.ru. B. Click 'Play'. In the case of radiorecord.ru, click another genre while another one is still playing. C. ISSUE: the content does not play (not at all i.e. is fully unresponsive or loads indefinitely, or might not play until user clicks pause and then play once again; either way, content is somehow 'overblocked' or at least not 'cleverly blocked'). On Twitch, the sound gets disabled and re-engaging it stops video playback. On radiorecord.ru, the second genre refuses to play (unless the first one is PAUSED!!); the intitial genre does not trigger the Autoplay 'Blocked' setting, at all, but the switch to another genre does trigger it, and incorrectly ignores user input ('Play').

  2. Playlists A. Go to (an affected?) site with playlists, e.g. a Youtube or bandcamp.com. B. Open a Playlist (site with multiple 'pre-loaded' pieces of content ordered for continuous playback). C. Click Play. D. ISSUE: insofar part 1 of this issue is not triggered, the file plays, but the next one does not. Having to click Play for every part of a playlist defeats its purpose!

Actual result:

All scenarios: (immediate) playback is blocked (see 'ISSUE' under repro steps for details).

Expected result:

  1. Playback should work
  2. 'Automatic' playback in playlist should potentially be allowed (probably more a feature request than a bug - maybe split?)

Reproduces how often:

100% - depending on specific site content playback technologies, and how the Brave protocols (do not) handle these, exactly.

Brave version (brave://version info)

Version 1.29.81 Chromium: 93.0.4577.82 (Official Build) (64-bit) Win10 Home 19042.1237

Version/Channel Information:

...

Other Additional Information:

No issue with Autoplay off. Shields do not seem to make a (bug) difference.

Chome repro TBD

Miscellaneous Information:

A few (potentially / somewhat) related issues, maybe this helps. Any linkage we could/should do? https://github.com/brave/brave-browser/issues/11247 https://github.com/brave/brave-browser/issues/13322 https://github.com/brave/brave-browser/issues/14266 https://github.com/brave/brave-browser/issues/13586 https://github.com/brave/brave-browser/issues/12557

wknapik commented 2 years ago

On bandcamp.com every band gets their own subdomain. With autoplay blocked by default, there's no way to play a song. Autoplay has to be disabled for the subdomain (so has to be done for each band separately). This seems like bug, since the browser is not just blocking autoplaying, it's blocking playing even when the user clicks play (and the solution/workaround enables autoplay, which the user probably doesn't want).

afritsch commented 2 weeks ago

Three years later, this is still an issue. Youtube playlists do not play the next video once it's loaded.